Skip to content

test: adjust tests so that grandchild gets stuck without fix#141

Closed
iiroj wants to merge 1 commit into
tinylibs:mainfrom
iiroj:fix-tests-failing
Closed

test: adjust tests so that grandchild gets stuck without fix#141
iiroj wants to merge 1 commit into
tinylibs:mainfrom
iiroj:fix-tests-failing

Conversation

@iiroj
Copy link
Copy Markdown
Contributor

@iiroj iiroj commented May 30, 2026

No description provided.

@iiroj iiroj force-pushed the fix-tests-failing branch from cac35f2 to b9d5777 Compare May 30, 2026 15:13
@iiroj
Copy link
Copy Markdown
Contributor Author

iiroj commented May 30, 2026

@43081j feel free to close this since I noticed you opened #140, but this PR adjusts the test so that it fails to SIGKILL if commit 20e4117 is reverted. It also doesn't require writing any temporary files, since I moved the spawner scripts to test fixtures.

console.log('output');
console.log('line1');
console.log('line2');
process.exit(0);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this is an issue of tinyexec, or is the root problem that the spawned script doesn't handle closing its own child process on exit?

@iiroj iiroj closed this May 31, 2026
@iiroj iiroj deleted the fix-tests-failing branch May 31, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant